refactor(1702-2): auto detect nft component

vinnyhoward commented 1 week ago

Description

This PR is part of a series that breaks down the original large PR #11127 into smaller, more manageable chunks.

The AutoDetectNFTSettings functionality is valuable beyond its original implementation. By converting it into a reusable component, we can:

Improve code maintainability
Reduce duplication
Enhance consistency across the application and ease of use

Changes

Extracted AutoDetectNFTSettings logic from its original location SecuritySettings and into a separate component file
Included new tests
Updated the SecuritySettings to use the new component
Removed related tests/constants within SecuritySettings and moved them into the new component folder

Impact

This refactored component will be used in:

Its current original screen which is SecuritySettings
New screens coming from the enhanced onboarding settings #1702 that is currently under progress

Related issues

Feature: #1702

Manual testing steps

On the wallet home screen, click on the NFTs tab and make sure they are there (use account with NFTs)
Goto the settings page
Click on Security Settings
Scroll down to Toggle the "Autodetect NFTs" and toggle to off
Check home screen under the NFT tab to make sure the enable Autodetect NFT banner is visible
Go back and toggle it back to on
Go back to the home screen wallet under NFT tabs. Make sure the banner is off

Screenshots/Recordings

Scenario 1	Scenario 2

Before

NA

After

NA

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[x] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 1 week ago

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 2681a9b5165e2a8b55d8dcf121b09711d31c0605 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2576f542-e407-4a81-9a3a-862bbf74b917

[!NOTE]

This comment will auto-update when build completes

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] commented 1 week ago

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 89ccef22466d77e2be8db7b3855c578f8a0bab27 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6416b678-9d2c-43f6-90c1-3bbadaa6cacd

[!NOTE]

This comment will auto-update when build completes

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request