MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.17k stars 1.12k forks source link

chore: Remove notifications logic from wallet view #12276

Closed tommasini closed 1 week ago

tommasini commented 1 week ago

Description

Removing notifications logic from wallet view because of a performance degredation. Investigations are still in progress.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 1 week ago

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 191599b289aa6b1c78612b17e0be74097cf52805 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d7a4b184-b580-4815-a037-6a2eeb91fa67

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
github-actions[bot] commented 1 week ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 235fcb9b10c2e02db677cc4ee18280541215b802 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f7939404-8c22-47b0-b5ef-63da6044db02

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise
github-actions[bot] commented 1 week ago

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 47616d5ee9b8acec8a77ea1205e238a4073cbcf2 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/384d804c-b26b-4366-a6e5-d6cc23b1b0e9

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

gauthierpetetin commented 3 days ago

Closes https://github.com/MetaMask/mobile-planning/issues/1949