feat(431): multi chain list and network filter - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.17k stars 1.12k forks source link

feat(431): multi chain list and network filter #12285

Open vinnyhoward opened 1 week ago

vinnyhoward commented 1 week ago

Description

The feature is currently hidden under a feature flag PORTFOLIO_VIEW to run and test run PORTFOLIO_VIEW=true yarn watch. Currently the app will crash without the necessary controller updates or patches

Related Pull Requests

https://github.com/MetaMask/metamask-mobile/pull/12293: Utility functions and type improvements to support multi-chain asset management
https://github.com/MetaMask/metamask-mobile/pull/12405 - Updating header

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.