chore: use getShares contract method from stake-sdk for unstake all flow

nickewansmith commented 1 week ago

Description

What is the reason for the change?

There was a quick fix for there being a share left in the vault after a user attempts to unstake all shares. This PR adds the long-term fix and upgrades the stake-sdk which added a new getShares method on the contract.

What is the improvement/solution?

We are now using the stake-sdk to access the getShares contract method instead of creating the interface on the fly.

Manual testing steps

Attempt to unstake all shares and all of them should unstake, leaving no option to unstake anymore.
There should be no change from before, as we only change the source we get the contract method from

Screenshots/Recordings

Before

After

https://github.com/user-attachments/assets/b9e7af8b-c421-482c-b3e2-d15982681520

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[x] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security[bot] commented 1 week ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/stake-sdk@0.3.0	network	`0`	169 kB	metamaskbot

🚮 Removed packages: npm/@metamask/stake-sdk@0.2.13

View full report↗︎

github-actions[bot] commented 4 days ago

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d0d9f4f28edf0a396823ccd6b825db9ddd785be5 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/35ace655-d2cd-4581-a70d-dbeb3d123060

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] commented 4 days ago

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 37387254ef958778a34e607ecdbb76605e0370cd Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4397c551-202c-411d-8232-69d7f042de40

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] commented 4 days ago

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3cf84c82791db348d339b88dcc7f45e8f2d338e1 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/51cca2c8-2848-48d4-ba63-1115487f32d5

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] commented 12 hours ago

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e56cd0df3a47ae07c0108caee68faaab4a330a0b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e9ea9e10-5bf1-44d0-b4a7-de61e185ed8b

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

Check the documentation if you have any doubts on how to understand the failure on bitrise