refactor: remove global network from transaction controller

matthewwalsh0 commented 1 week ago

Description

Upgrade @metamask/transaction-controller to remove all usages of the global network.

Specifically:

Create global network utils including:
- getGlobalChainId
- getGlobalNetworkClientId
- getGlobalEthQuery
Add networkClientId to calls to:
- addTransaction
- estimateGas
- getNonceLock
- startIncomingTransactionPolling
- updateIncomingTransactions
Update calls to:
- getTransactions
- wipeTransactions
Add networkClientId to Redux transaction object.
Add networkClientId to Stake type in StakeContext.
Add networkClientId argument to transaction utils:
- getMethodData
- isSmartContractAddress
Add networkClientId to test data.

Related issues

Fixes: #3499

Manual testing steps

Full regression of all transaction flows.

Screenshots/Recordings

Before

After

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[x] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security[bot] commented 1 week ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/controller-utils@11.4.3	network	`0`	264 kB	metamaskbot

🚮 Removed packages: npm/@metamask/controller-utils@11.4.2

View full report↗︎

github-actions[bot] commented 1 week ago

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 93dde7c28fc6717303de7b21f2c16393c20fbadc Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/743430ce-5215-4107-882e-c4cf472944c3

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] commented 1 week ago

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 753e7a4cec65428eef2dd4e764575c6fdb3234f7 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b04c4fe3-cdd6-47ad-a83a-2cc9e3980695

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

Check the documentation if you have any doubts on how to understand the failure on bitrise

sonarcloud[bot] commented 6 days ago

Quality Gate failed

Failed conditions
57.4% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

github-actions[bot] commented 6 days ago

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0ec821714880e12a84911760bf9b4509ec9283ab Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3914c865-c651-46f7-a9ce-ac9b1edcb5ed

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sleepytanya commented 6 days ago

Bitrise QA builds https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/256a579f-cde8-4d78-a063-4c08f56d1da8?tab=workflows

Speed up / Cancel /queueing work normally
When a user attempts to customize the transaction nonce, the nonce values are displayed as "Undefined" or "Not a Number":

iOS

https://github.com/user-attachments/assets/ba0d186e-35d4-4c63-9892-321ea3720685

Android

https://github.com/user-attachments/assets/26c8f9fc-b998-44c0-b1a7-485c45c47ccb

After completing several successful transactions, chainID error appears, preventing further transactions from being created, present on all Popular networks:

iOS