MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.18k stars 1.12k forks source link

chore: cherrypick do not show staked eth balance when balance is zero on homepage or asset detail #12335

Closed nickewansmith closed 5 days ago

nickewansmith commented 6 days ago

Description

  1. What is the reason for the change?

We have decided that we should hide the staked ethereum balance if it is 0 on mobile.

  1. What is the improvement/solution?

Ensure that the staked ethereum asset does not show when the balance is zero on the homepage and on the ETH asset detail page.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/STAKE-874

Manual testing steps

  1. On this branch
  2. If you have a zero Staked ETH balance, you should see no Staked Ethereum asset on the homepage or on the ETH asset detail page after clicking the ETH asset on homepage.
  3. If you do have Staked ETH already, then you should see that ETH on the homepage and on the ETH asset detail page as well. Unstake Max ETH and wait for transaction to confirm. When you check homepage and ETH asset detail page, there should be no Staked Ethereum listed as balance is now 0.

Screenshots/Recordings

Before

https://github.com/user-attachments/assets/04e475ad-f8c0-49f1-aaeb-a5a8df25e44b

After

https://github.com/user-attachments/assets/35ea9834-ff42-4667-87d2-cc510ff91155

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 6 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 6 days ago

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e8f0bfe4464eaea1e956c439d725f9f97544f28e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b1ead058-3d38-4f1b-b720-e30337cd33bc

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
30.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud