MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.18k stars 1.12k forks source link

build(2808): edit network permissions, do not merge, toggle the mulitchain feature flag ON, and refac…tor the flag #12336

Open EtherWizard33 opened 6 days ago

EtherWizard33 commented 6 days ago

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 6 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 6 days ago

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 39bc469f4d11912e7f6d28377b81faa6ba3dd05e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be80cc68-0afd-45bc-a876-579951e3ce1d

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
codecov-commenter commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.32%. Comparing base (22a4989) to head (39bc469). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12336 +/- ## ========================================== - Coverage 56.41% 56.32% -0.09% ========================================== Files 1797 1796 -1 Lines 40586 40539 -47 Branches 5097 5097 ========================================== - Hits 22896 22835 -61 - Misses 16134 16142 +8 - Partials 1556 1562 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

github-actions[bot] commented 6 days ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2f96bf7195bbcf92452361a415cef34ab30a3317 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9d8dfba-5ff4-4595-a4c3-c354e974fa7e

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise
sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud