chore/ Update accounts-controller @v19.0.0 and keyring-controller @v18.0.0

owencraston commented 2 days ago

Description

This PR updates the accounts controller to the latest version of 19. This updates requires a peer dependancy bump of the keyring controller to version 18.0.0

See accounts controller changelog.
See keyring controller changelog.
- version 18 of the keyring controller removes the addNewAccountWithoutUpdate which is used once in the mobile repo. In order to merge this PR we will need to wait for @mikesposito's PR to merge. This PR removes the need for addNewAccountWithoutUpdate and improves performance/reliability.

Blocked by: https://github.com/MetaMask/metamask-mobile/pull/11409

Manual testing steps

Account creation

open app
press create wallet
go through the onboarding flow
once onboarding is complete, you should be on the wallet view and see a single account
open the account selector list and add a new account'
this should work without issues
change the name of your new account
force close the app and reopen, the previously selected account should be the same and the custom name should be preserved.

Account importing

assuming you have created a wallet wth the above steps....
open the account selector list and click add account or hardware wallet and then click import account
paste a private key in this text field and then import
the account should be imported, selected and have the label "imported"
force closing the app and re opening it should preserve the same state of accounts

Hardware wallets

assuming you have created a wallet wth the above steps....
open the account selector list and click add account or hardware wallet and then click Add hardware wallet
select your hardware wallet of choice (ledger or qr based)
follow the instructions to add a hardware wallet
the steps should work and you should have successfully added a hardware account
the hardware account should have the correct labels (either Qr hardware or ledger)
force closing the app and reopening should preserve the same accounts state.

Screenshots/Recordings

Before

After

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 2 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security[bot] commented 2 days ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/accounts-controller@19.0.0	None	`0`	267 kB	metamaskbot
npm/@metamask/approval-controller@7.1.1	None	`0`	221 kB	metamaskbot
npm/@metamask/eth-snap-keyring@4.4.0	Transitive: network	`+3`	3.17 MB
npm/@metamask/json-rpc-engine@10.0.1	None	`0`	178 kB	metamaskbot
npm/@metamask/json-rpc-middleware-stream@8.0.5	None	`0`	49.9 kB	metamaskbot
npm/@metamask/keyring-controller@18.0.0	Transitive: environment	`+2`	630 kB	danfinlay, gudahtt, kumavis, ...7 more
npm/@metamask/snaps-controllers@9.12.0	Transitive: network	`+3`	2.86 MB	danfinlay, gudahtt, kumavis, ...7 more
npm/@metamask/snaps-rpc-methods@11.5.1	None	`0`	1.23 MB	metamaskbot