feat: upgrade assets controllers to version 43

bergeron commented 5 days ago

Description

Upgrades the assets controllers to versiom 43, which allows polling for token detection and token lists across chains.

It also lets us remove the patch for staking.

Manual testing steps

With PORTFOLIO_VIEW=false and PORTFOLIO_VIEW=true:

Onboard
Verify erc20 tokens are detected correctly
Switch chains
Verify they're detected correctly on the new chain

Screenshots/Recordings

No visual changes

Before

After

https://github.com/user-attachments/assets/709ca6ba-69b8-4ec8-8fce-d358c7f39b27

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 5 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security[bot] commented 5 days ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/assets-controllers@43.1.1	None	`+1`	2.12 MB	danfinlay, gudahtt, kumavis, ...7 more

🚮 Removed packages: npm/@metamask/assets-controllers@42.0.0

View full report↗︎

github-actions[bot] commented 5 days ago

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f6f76467d3206ae5747a8884b6ea655084d45577 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f6e22f54-3c2f-4ecb-81d8-31b8a52fbc79

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud[bot] commented 4 days ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions[bot] commented 4 days ago

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 09bc62b8c185c987db68ce74dacbb849f0fbbe8d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8ff171f9-118c-4f15-8568-e17ef10cff69

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

MetaMask / metamask-mobile