MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.17k stars 1.12k forks source link

feat: upgrade assets controllers to v44 #12344

Open bergeron opened 2 days ago

bergeron commented 2 days ago

Description

Upgrades the assets controllers to v44. In this version, the token balances controller now stores erc20 balances across all chains and accounts, instead of just the current chain and account like before. This allows polling erc20 balances across chains.

Related issues

Depends on: https://github.com/MetaMask/metamask-mobile/pull/12340

Manual testing steps

With PORTFOLIO_VIEW=false and PORTFOLIO_VIEW=true:

  1. Onboard
  2. Verify erc20 tokens have correct balances
  3. Switch chains
  4. Verify the erc20 tokens on the new chain have correct balances
  5. Send a TX that changes an erc20 balance
  6. Verify it gets updated after tx completes

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 2 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security[bot] commented 2 days ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@44.1.0 None +3 3.08 MB metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@43.1.1

View full report↗︎

github-actions[bot] commented 1 day ago

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6db4a2f87fe47a60c8db5700a21c363ae10f89c4 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/00e2d891-a3d2-4fb5-9ce3-d2d50c2cfd63

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
62.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud