MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.17k stars 1.12k forks source link

fix: Remove stateless "non-controllers" from background engine state #12348

Closed MajorLift closed 35 minutes ago

MajorLift commented 2 days ago

Description

Related issues

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 2 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security[bot] commented 2 days ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask-previews/composable-controller@9.0.1-preview-335c4644 None 0 69.8 kB mcmire, metamaskbot

🚮 Removed packages: npm/@metamask/composable-controller@9.0.0

View full report↗︎

github-actions[bot] commented 2 days ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 85c17e1f7aa6229644e5d72bf743d7d3c0fc57f9 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f442d0cb-1b62-416c-9928-135dee1cba90

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise
sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud