MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.17k stars 1.12k forks source link

chore: Bump Snaps packages #12350

Open FrederikBolding opened 2 days ago

FrederikBolding commented 2 days ago

Description

Bumps all Snaps packages to their latest versions and deletes some unnecessary fetch polyfilling code. This fixes an issue where local Snaps would fail to install in the Flask flavor of mobile.

socket-security[bot] commented 2 days ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/approval-controller@7.1.1 None 0 221 kB metamaskbot
npm/@metamask/json-rpc-engine@10.0.1 None 0 178 kB metamaskbot
npm/@metamask/json-rpc-middleware-stream@8.0.5 None 0 49.9 kB metamaskbot
npm/@metamask/providers@18.1.1 None 0 439 kB metamaskbot
npm/@metamask/snaps-controllers@9.13.0 None 0 1.65 MB metamaskbot
npm/@metamask/snaps-execution-environments@6.10.0 None 0 5.71 MB metamaskbot
npm/@metamask/snaps-rpc-methods@11.5.1 Transitive: network +1 2.59 MB metamaskbot

🚮 Removed packages: npm/@metamask/approval-controller@7.1.0, npm/@metamask/json-rpc-middleware-stream@8.0.2, npm/@metamask/permission-controller@11.0.0, npm/@metamask/providers@17.2.1, npm/@metamask/snaps-controllers@9.11.0, npm/@metamask/snaps-execution-environments@6.7.2, npm/@metamask/snaps-registry@3.2.1, npm/@metamask/snaps-rpc-methods@11.4.0

View full report↗︎

github-actions[bot] commented 1 day ago

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 74ba840a69fef25763a5f69db238a3f62d4b9d03 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/218590aa-f916-4386-afb4-6424c67a2abb

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
owencraston commented 1 day ago

This change progresses the issues I was previously experiencing with local snaps but does not resolve them. I am testing the bitcoin snap and when I run it locally I get the following error.

Simulator Screenshot - iPhone 13 mini - 2024-11-20 at 15 29 12

Logs:

[Error: Failed to fetch snap "local:http://localhost:8080": Failed to fetch "http://localhost:8080/snap.manifest.json". Status code: 404..]

whats even weirder is that if I navigate to http://localhost:8080/snap.manifest.json on the apps browser I see the manifest data.

Simulator Screenshot - iPhone 13 mini - 2024-11-20 at 15 26 48

Steps:

  1. Clone Bitcoin repo
  2. checkout the branch fix/allow-mobile. This will allows the dapp to install on mobile which does not have the same in page providerr.
  3. run yarn install && yarn start
  4. open the metamask mobile app in the simulator. Make sure the sim is running on the same machine as the local snap
  5. after onboarding and creating a wallet, open the in app browser and paste the snap site url into the url box. http://localhost:3000/
  6. click connect and see what happens.
sonarcloud[bot] commented 4 hours ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)
78.4% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud