refactor(ramp): remove anonymous events - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.18k stars 1.12k forks source link

refactor(ramp): remove anonymous events #12351

Closed wachunei closed 4 days ago

wachunei commented 5 days ago

Description

This PR removes all of the anonymous events from the Ramp analytics setup

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-2034

Manual testing steps

Go to Buy or Sell flow
Confirm the events are being tracked

Screenshots/Recordings

Before

After

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[x] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 5 days ago

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3498405e1b7957b653b2e318df57a1756ab2b9ed Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d96c1576-2050-4675-8911-b127134c21e4

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] commented 5 days ago

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c5bdb9f5deee4ac509002cfe0fe38417cbd8f721 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3290b16d-b1c4-4c5a-a0ae-0d599b2256c2

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] commented 4 days ago

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 87707b91742b128d423fba6fc1f3db30c815a065 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a97da60-3122-41fc-bcd6-197acfec7e8e

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud[bot] commented 4 days ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud