chore: Optimize navigation entry file re renders

tommasini commented 2 days ago

Description

This draft was able to optimize re-renders of the navigation entry file (nav/app/index.js) from 5 to 2 re renders on cold app starts, on fresh installs, and when the user already has an account imported.

One issue was found when importing via SRP, after importing the user was stuck on the fox loader screen.

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

https://github.com/user-attachments/assets/52650c17-fb1a-4e3c-ac19-041bcc23a671

https://github.com/user-attachments/assets/1b4422cf-0935-4851-b1d5-f9f7e650d54a

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.