chore: Add missing confirmation unit tests - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.17k stars 1.12k forks source link

chore: Add missing confirmation unit tests #12355

Closed OGPoyraz closed 5 hours ago

OGPoyraz commented 2 days ago

Description

This PR purely adds missing confirmation unit tests and improve snapshot testing.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3584

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

sonarcloud[bot] commented 1 day ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud