MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.17k stars 1.12k forks source link

chore: Remove unnecessary event prop #12356

Open dan437 opened 1 day ago

dan437 commented 1 day ago

Description

Removes an unnecessary event prop smart_transaction_duplicated, as we did in the extension: https://github.com/MetaMask/metamask-extension/pull/28546

Related issues

Fixes:

Manual testing steps

  1. This event prop won't be available anymore in some events after submitting a smart transaction.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 1 day ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 1 day ago

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a9af883cd7736e14eaf85f8d4b3c0f7a47e0f5e1 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2f1b09a4-cff9-4788-aa99-a14d08b3f61e

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud