Closed sahar-fehri closed 4 days ago
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
✅✅✅ pr_smoke_e2e_pipeline
passed on Bitrise! ✅✅✅
Commit hash: 355332262fffdd14548ae6fa31f1be5dd4da97fb Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8ea1511e-c6c4-4043-bcdc-4cc7a87c23b7
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipeline
on Bitrise by removing and re-applying theRun Smoke E2E
label on the pull request
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@sahar-fehri Can you link the PR for the fix in core to this issue?
Hi @sethkfman! I did not create a core PR for this; Im thinking this patch wont be needed anymore because the latest version of tokenBalancesController on core today no longer matches the implementation in the patch; it no longer calls balanceOf
for each token and we no longer have the for
loop. Instead we use the multicall3 contract to fetch ERC20 balances in a single RPC call;
I will close this one and recreate the fix for the 44 upgrade that was merged
Description
fixes sentry issue
Related issues
Fixes: https://github.com/MetaMask/metamask-mobile/issues/12326
Manual testing steps
No functionality updates
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist