MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.17k stars 1.12k forks source link

chore(runway): cherry-pick fix: tags pending approvals receiving undefined #12361

Closed runway-github[bot] closed 1 day ago

runway-github[bot] commented 1 day ago

Description

Fix this: https://metamask.sentry.io/issues/6063420089/events/d1047fbf9e814a6d9fc0c86bf2115f2a/?project=2299799&referrer=previous-event

selectPendingApprovals may return undefined, and when we do Object.values(undefined) a error is thrown

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 1 day ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sentry-io[bot] commented 1 day ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/util/sentry/tags/index.ts

Function Unhandled Issue
getTraceTags TypeError: Object.values requires that input parameter not be null or undefined e.getTraceT...
Event Count: 473 Affected Users: 7.7k

Did you find this useful? React with a 👍 or 👎

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud