chore: [DON'T MERGE] Bump `swaps-controller` to test removal of global provider

mcmire commented 4 days ago

Description

This is a PR to test https://github.com/MetaMask/swaps-controller/pull/347, which removes most of SwapsController's reliance on the global provider.

It may be converted into a "real" PR later.

Related issues

Also see:

Manual testing steps

Tap on the Swap button
Select a destination token and proceed
You should see new quotes

Screenshots/Recordings

Before

Not provided since it should be whatever it is now.

After

https://github.com/user-attachments/assets/62a490c9-32c4-49a2-886d-136328761658

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 4 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security[bot] commented 4 days ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask-previews/swaps-controller@11.0.0-preview-40be04506cf92f5e6a271eb90c96b4ddcf57dd5d	None	`0`	281 kB	mcmire

🚮 Removed packages: npm/@metamask/swaps-controller@10.0.0

View full report↗︎

mcmire commented 3 days ago

Need to add missing unit tests in order to make SonarCloud pass on this, but all of the existing unit tests should pass and you should be able to follow the manual testing steps listed in the PR description.

sonarcloud[bot] commented 3 days ago

Quality Gate failed

Failed conditions
35.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

MetaMask / metamask-mobile