fix(431-2): active network icon has too much margin and adding optional prop

vinnyhoward commented 3 days ago

Description

The active network icon in the header has too much margin and is misaligned with the network title.

I have also added an optional prop of networkName that allows developers to pass in the network name of their choice. This is in preparation of multichain support, currently we are showing the selected network name, in multichain we want to be able to pass in a network name and not the selected chain.

Related issues

Fixes:

Manual testing steps

Goto asset details, swaps, or buy. Basically any screen that has the header with network name

Screenshots/Recordings

(green icon at the very top)	Before	After

Before

NA

After

NA

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.