chore: Chore/update accounts controller messenger code owner

Cal-L commented 15 hours ago

Description

This PR moves the AccountsController restricted messenger back into the Engine to ensure that platform team is notified of any changes. It also ensures that the AccountsController throws if initialization fails, persisting the behavior of how it was before.

Related issues

Fixes: Related #12366

Manual testing steps

No changes for app behavior. Operate as usual. Ensure that e2e passes

Screenshots/Recordings

Before

After

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[x] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 15 hours ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 15 hours ago

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4943178beb0f46eeffd14267a1ab60e05fac10c2 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/61bc1fdf-3418-448e-8f36-2cc7c07957e8

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

Check the documentation if you have any doubts on how to understand the failure on bitrise