MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.15k stars 1.1k forks source link

Second transaction is not shown to the user #1249

Closed PaulRBerg closed 4 years ago

PaulRBerg commented 4 years ago

Description

Here's my transaction flow:

  1. Approve token
  2. Submit dapp tx

And an approximation for my JavaScript code that creates these two transactions (with ethers.js).

const txs = [];
const tokenApprovalTx = await createTokenApprovalTx();
txs.push(tokenApprovalTx);
const sablierTx = await createSablierTx();
txs.push(sablierTx);

The 2n transaction is not picked up by the mobile browser and the user doesn't see it at all.

Expected Behaviour

The user should be prompted to sign the 2nd transaction, even if they just previously submitted another one.

Steps

  1. Go to pay.sablier.finance
  2. Log in
  3. Have some Eth and Dai
  4. Tap "Stream Money"
  5. Fill the form with "0.01", any recipient and any duration (caveat: if you don't pay yourself, the money is lost)
  6. Submit form

Environment

PaulRBerg commented 4 years ago

Any updates on this? Our web interface cannot be used with Metamask Mobile at all.

brunobar79 commented 4 years ago

@PaulRBerg Can you add to the code snippet of what do you do with the tx array? That will help a lot.

PaulRBerg commented 4 years ago

Hey @brunobar79 I created a gist for you:

https://gist.github.com/PaulRBerg/eadb8eeed13f0cb7d8576723948d532c

See the submit function.

dpazdan commented 4 years ago

related support case 29299

dpazdan commented 4 years ago

I was able to replicate this bug when trying to add OXT tokens to orchid account setup: http://account.orchid.technology/

PaulRBerg commented 4 years ago

I haven't tested it, but the same bug might occur on gitcoin.co/grants too. They have a similar transaction flow.

brunobar79 commented 4 years ago

Thanks for the info. I'm gonna create a very simple repro app in ropsten to be able to debug better.

danjm commented 4 years ago

@PaulRBerg Can you confirm that this is still a bug?

PaulRBerg commented 4 years ago

@danjm it works well on version 0.2.14. I'll close this issue for now.

Thanks for the fix!