MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

Browser doesn't reset upon creation of new wallet #1660

Open ibrahimtaveras00 opened 4 years ago

ibrahimtaveras00 commented 4 years ago

Describe the bug

When creating a new wallet, browser keeps the same information (favorites + connected dapps)

Screenshots

Seen here = https://recordit.co/xiyrAZjtq5

To Reproduce

  1. Go to browser
  2. Select a dapp and connect
  3. Save as favorite
  4. Logout and create a new wallet
  5. Go back to browser and notice your browser is still in the same state

Expected behavior

Browser should be reset [update]: close all open tabs + ensure all previously connected sites are disconnected

Smartphone (please complete the following information):


to be added after bug submission by internal support / PM Severity

rickycodes commented 3 years ago

do we want to blow out favorites and connected dapps when a user creates or imports a new wallet? I feel like there might be value in keeping the old favorites? /cc @omnat

omnat commented 3 years ago

Good point. Agree, there's value in keeping old favorites. After a wallet reset, we should still close the open tabs, as the old 'connected dapps' won't work with the new wallet.

AlexJupiter commented 2 years ago

For this to be closed we should do Omna's suggestion above:

After a wallet reset, we should still close the open tabs, as the old 'connected dapps' won't work with the new wallet.

hesterbruikman commented 1 year ago

Needs architectural review fore feasibility cc @sethkfman