BSC related issues - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.16k stars 1.11k forks source link

BSC related issues #2766

Closed estebanmino closed 3 years ago

estebanmino commented 3 years ago

Description

We have many sentry logs for different RPC calls happening on binance / pancake swap, mostly all of those are described in https://docs.pancakeswap.finance/help/troubleshooting with manual steps for their users.

execution reverted: PancakeRouter: INSUFFICIENT_OUTPUT_AMOUNT
Error: execution reverted: Pancake: K
Error: missing value for required argument 1 in https://poocoin.app/ , dapp.moonshield.finance and probably others

Technical Implementation

Acceptance Criteria

sentry-io[bot] commented 3 years ago

Sentry issue: METAMASK-MOBILE-NFJ

sentry-io[bot] commented 3 years ago

Sentry issue: METAMASK-MOBILE-KW3

sentry-io[bot] commented 3 years ago

Sentry issue: METAMASK-MOBILE-KVX

sentry-io[bot] commented 3 years ago

Sentry issue: METAMASK-MOBILE-KGR

sethkfman commented 3 years ago

Needs technical review to identify items that are still issues

andrepimenta commented 3 years ago

This doesn't seem to be an error from our side. For example, for execution reverted: PancakeRouter: INSUFFICIENT_OUTPUT_AMOUNT, this usually happens when trading tokens with low liquidity. For all the other errors there are similar examples. We might want to figure out a way of ignoring these errors.

andrepimenta commented 3 years ago

Created a new ticket for cleaning this sentry log https://app.zenhub.com/workspaces/metamask-mobile-5f984938ddc0e4001d4b79cb/issues/metamask/metamask-mobile/3264