MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.11k stars 1.09k forks source link

Adding iPad Support #3488

Open akaraatanasov opened 2 years ago

akaraatanasov commented 2 years ago

Describe the usability problem When using the MetaMask app on an iPad, the app doesn't fill the entire screen - it's a "streched" iPhone app. This is affecting the user experience of iPad users and I've seen other people on Reddit (#1, #2) requesting the same change. Please, implement this whenever possible. I really like using MetaMask and this is the only UX breaking issue I'm currently having with the app, and I would be very happy if this gets implemented.

Expected behavior The app should fill the entire screen.

Technical Details I get that this might not be something of top priority, however the changes needed to add iPad support are very minimal and the user experience for all iPad users will drastically improve. The app layout already supports dynamic screen sizes, it's just that iPad support is disabled. In the project settings of the iOS subproject, under Deployment Info, the iPad checkmark should be set to enabled like so:

settings

When this is done, the app starts to fill the entire screen and it looks pretty good IMO. Here are some iPad Pro 12.9" Simulator screenshots I've taken to prove my point. No other changes are applied except applying the iPad checkmark mentioned above.

Screenshots Before After
home-portrait-before home-portrait-after
menu-portrait menu-portrait-after
popup-portrait popup-portrait-after
browser-portrait browser-portrait-after

P.S: Landscape support for iPad would also be nice, but I totally understand that it's out of scope of this issue and would require a bit more work than adding iPad support.


filled out after submission

User impact | Usage frequency | Feasibility scores How important is this to the user, what the user wants to accomplish | Daily, weekly, monthly | Small, medium, large

akaraatanasov commented 2 years ago

@Cal-L could someone look into this? Also, what's the process for me to be able to issue a PR myself?

edsonayllon commented 2 years ago

Any way this could be prioritized @wachunei? Using the dapp browser on iPad is currently awful. The workaround which isn't too great is using wallet connect with a normal browser. However, switching networks this way is a pain.

varanauskas commented 2 years ago

I’ve opened another issue that would be a different way of solving this problem by just being able to access MetaMask from safari: #4373

edsonayllon commented 2 years ago

I’ve opened another issue that would be a different way of solving this problem by just being able to access MetaMask from safari: #4373

Would this solution allow using Ledger hardware wallet like is being worked on in Metamask mobile?

gglucass commented 1 year ago

Bumping this as this seems to be a simple fix that would resolve a lot of the immediate problems people are experiencing. Would be great if this can be done @wachunei @edsonayllon !!

edsonayllon commented 1 year ago

Any updates on this? We're approaching a year now @gantunesr

wachunei commented 1 year ago

I have opened a new PR #5312

Janislav commented 6 months ago

Is there any plan to finsih this? It looked like the PR was alreday pretty close to get merged but then it was closed. There is no WEB3 Wallet/Browser out there that supports running in iPad mode and doing Web3 things on an iPhone is painful, dangerous and dosent make a lot of sense anyway... It looks like a low hanging fruit to me which would improve Metamask and the Web3 world a lot. Apple devices are consdiered quite save by design which is great for Web3. So pls do me a favour and enable iPad mode :D. Let me know if I can help.

AminTakhtiNejad commented 2 months ago

its been years. we need ipados support!