Update the 'Settings' UI to make the privacy settings consistent with the new UI of 'Advanced Privacy Settings'

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.04k stars 1.06k forks source link

Update the 'Settings' UI to make the privacy settings consistent with the new UI of 'Advanced Privacy Settings' #5313

Open omnat opened 1 year ago

omnat commented 1 year ago

Description

Enable users to quickly access the privacy settings associated with the application.

Technical Details

Move the existing privacy settings that are scattered in Settings > Advanced, Settings > Security & Privacy screens to the new Advanced Privacy Settings screen
Change 'Security & Privacy' tab to 'Security'
Ensure no existing privacy functionality is deleted as a result of this re-organization of setting options in the UI
Maintain the navigations from other parts to the apps to settings (NFTs)

Acceptance Criteria

Security & Privacy View has been retitled to Security
A new Advanced Privacy Settings View is displayed with content below
Defaults for each of these settings should remain the same
Translations are not required

References

Figma Advanced Privacy Settings Component V2: https://www.figma.com/file/4gkmBwSE9qkecCS69pwsG3/Onboarding-Redesign?node-id=1533%3A64887&t=1plB5Tye67SRMvjf-4

SaraCheikh commented 1 year ago

Hi @omnat, This ticket is part of of the advanced privacy settings design I'm working on, could you please assign it to me so I can keep track of it and update it? (I'm unable to do it!)

sethkfman commented 1 year ago

@omnat A comment was added in the figma but there is not a currently a use phishing detection toggle in settings. Can you provide more information on this? If this is required, we should have a separate ticket for implementing.

sethkfman commented 1 year ago

Consider breaking each these section into a separate ticket for implementation and defining the anchors in the technical definition.

Can these be delivered a separate tickets?

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 7 days with no activity. If you feel this was closed in error please reopen and provide evidence on the current production app. Thank you for your contributions.

gauthierpetetin commented 12 months ago

Hi @sethkfman @yanrong-chen , it this ticket a priority? I'm just afraid of reorganising our settings differently, while they're currently structured in the same way as Extension does. If we want to work on this ticket, maybe we shall align with Extension first on the updated target structure?

yanrong-chen commented 12 months ago

@gauthierpetetin Extension already has a similar design of separating privacy from security [in this Figma file:https://www.figma.com/file/4gkmBwSE9qkecCS69pwsG3/Onboarding-Redesign?type=design&node-id=1533-64887&mode=design&t=ysuXFuSwRtTklZ8o-0] I'm not sure when that would get implemented though.

gauthierpetetin commented 12 months ago

Thanks @yanrong-chen , that's very helpful. cc @Cal-L for visibility @kevinghim ,do you know if there's a corresponding issue in Extension's backlog as well? If not, I can create one

gauthierpetetin commented 11 months ago

This separation of Privacy and Security is not a priority to achieve this quarter's OKRs.

It's a nice-to-have and we might address it later in the quarter once our OKRs are achieved.