☂️ Fix remaining TS/TSX static type errors

[leotm]

Describe the issue Increase ability to catch bugs at compile time. I.e. identify and resolve faster.

This is a follow-up to

• https://github.com/MetaMask/metamask-mobile/issues/5878
• https://github.com/MetaMask/metamask-mobile/issues/5881

which enables TSC to emit our remaining TS/TSX type errors to fix ~570ish errors in ~90ish files, tracked in our internal google sheet

• https://github.com/MetaMask/metamask-mobile/pull/6080

once complete at 0 errors (and 0 warnings ideally) we can re-enable TSC in our pre-commit hooks and CI

• https://github.com/MetaMask/metamask-mobile/issues/4605
  • already partially complete in https://github.com/MetaMask/metamask-mobile/pull/7100

then later upgrade to TypeScript v5 once our MM shared ESLint config is on v5

• https://github.com/MetaMask/metamask-mobile/issues/5984

a good long-term follow-up would be

• converting remaining .js files to ts remains, a huge task worthy of it's own umbrella issue / epic
  • e.g. app/util/transactions/index.js -> app/util/transactions/index.ts (no changes) exposes
  • Found 234 errors in 48 files -> Found 394 errors in 50 files

Screenshots

In issues above ^

To Reproduce

yarn tsc

Expected behavior

0 errors 0 warnings (ideally)

Smartphone (please complete the following information):

N/A

---

to be added after bug submission by internal support / PM Severity

• How critical is the impact of this bug on a user?
• Add stats if available on % of customers impacted
• Is this visible to all users?
• Is this tech debt? yes

[hesterbruikman]

@leotm @Cal-L

Added a note to give context to this work and make it easier to discuss relevance:

"Increase ability to catch bugs at compile time. I.e. identify and resolve faster."

Any other reasons for why this work should be prioritised? Dependencies with libraries?

[leotm]

Any other reasons for why this work should be prioritised?

we could add correct types make it easier (and more welcoming) working on our codebase as well as getting VS Code clean/free of type errors (linted in red @sethkfman raised originally)

[leotm]

Dependencies with libraries?

the main one to note is https://github.com/MetaMask/metamask-mobile/issues/5984 depends on https://github.com/MetaMask/eslint-config/releases/tag/v12.1.0 which was released last month so no longer blocking the TS v5 upgrade