search

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.16k stars 1.11k forks source link

ApproveTransactionReview - extract code to render QR details into separate component #6161

Open jpuri opened 1 year ago

jpuri commented 1 year ago

Extract code here to render QR details to separate component: https://github.com/MetaMask/metamask-mobile/blob/f5d3bb82924bce231fee76ef29d7ba077886bc17/app/components/UI/ApproveTransactionReview/index.js#L996

jpuri commented 1 year ago

I did a fix for this task in this PR itself: https://github.com/MetaMask/metamask-mobile/pull/6213 but it was found to have issues when tested with QR wallet.

I am moving it bask to Ready for Dev to implement it once we have QR hardware wallet in the team for testing.

bschorchit commented 1 year ago

I moved it to the next sprint as the QR hardware wallet should take 1-2 weeks to arrive