search

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.16k stars 1.11k forks source link

[Bug] Performing a Send from a Dapp displays Hex Data even if the option is disabled from Advanced Settings #6364

Open seaona opened 1 year ago

seaona commented 1 year ago

Describe the bug Whenever I disable displaying Hex Data from Advanced Settings, I can see how the View Data option is still there if I perform a Send (Send Legacy / Send EIP1559) from a Dapp.

Screenshots

https://github.com/MetaMask/metamask-mobile/assets/54408225/17be1110-ea53-4c6a-86bd-903d63f7b77d

To Reproduce Steps to reproduce the behavior

  1. Go to Advanced Settings
  2. Disable Hex Data
  3. Go to the test dapp https://metamask.github.io/test-dapp/
  4. Connect MetaMask
  5. Click Send EIP1559 or Send Legacy
  6. See View Data is displayed
  7. Click View Data see hex data

Expected behavior If Hex Data is disabled from Settings, we should not see it on a Send from a test dapp.

Smartphone (please complete the following information):

to be added after bug submission by internal support / PM Severity

hesterbruikman commented 1 year ago

related to #6482 and #6484

tommasini commented 1 year ago

Just to update here, this issue is still happening. It seems that when we have the nonce enabled we can not see the hex data either https://recordit.co/omrfjpW8on

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 7 days with no activity. If you feel this was closed in error please reopen and provide evidence on the current production app. Thank you for your contributions.