search

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.13k stars 1.1k forks source link

[Bug] Saved contract contact from a dapp transaction is not displayed when initiating a transaction from inside the Wallet #6483

Open seaona opened 1 year ago

seaona commented 1 year ago

Describe the bug Whenever we are performing a transaction from a dapp, we can save the contract recipient address into the Address Book. Once we've saved the contact, if we go inside the main wallet view and initiate a Send transaction from there, we don't see our saved contact anywhere.

However we can see how the contact is saved on the Settings/Contacts tab.

Notice: this behavior only happens with Contact which are contract addresses.

Screenshots

https://github.com/MetaMask/metamask-mobile/assets/54408225/46803d74-cb20-4c5c-bc5b-d079d203b352

To Reproduce Steps to reproduce the behavior

  1. Go to test-dapp
  2. Deploy a contract i.e. Multisig
  3. Click Send ETH to Multisig
  4. Save the address into the address book
  5. Go back to the wallet
  6. Click Send
  7. See how the newly saved contact is not displayed on the recipients list
  8. Go to Settings / Contacts
  9. See how the contact is there

Expected behavior We should see the contact on the recipient's list whenever we Send a transaction from inside the Wallet.

Smartphone (please complete the following information):

to be added after bug submission by internal support / PM Severity

bschorchit commented 1 year ago

I'm also able to reproduce on iOS v6.3.0. Possibly related with https://github.com/MetaMask/metamask-mobile/issues/4871

Andepande commented 1 year ago

image.png

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] commented 12 months ago

This issue was closed because it has been stalled for 7 days with no activity. If you feel this was closed in error please reopen and provide evidence on the current production app. Thank you for your contributions.

rafae667 commented 10 months ago

Still able to reproduce it

bschorchit commented 3 months ago

Removing team-confirmations label and adding team-bridge label as this is an issue specific of the send flow.