Replace TextInput component with TextField from the component-library

georgewrmarshall commented 1 year ago

Description

Currently, mobile is using the React Native TextInput component, which needs to be replaced with the new TextField component.

This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements.

Technical Details

Replace instances of TextInput component (react-native) with TextField component (app/component-library/components/Form/TextField/TextField.tsx)
Component APIs are slightly different so ensure all props have been migrated appropriately

Acceptance Criteria

Instances of TextInput component are completely replaced with the new TextField component
The component APIs are updated to reflect the changes in the new `TextInput`` component and there is no functional changes or visual regression
Each Pull Request (PR) should include no more than 3 files
The code changes should pass Jest tests, e2e tests, linting, and Storybook without any errors.
The PR must include before and after screenshots of the UI to ensure there are no visual regressions.

If the acceptance criteria is not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running mobile locally, have knowledge of React Native, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in mobile

web3metaversee commented 1 year ago

Like 😉

MridulY commented 4 months ago

Hey I would like to work on this @georgewrmarshall

georgewrmarshall commented 4 months ago

Hi @MridulY ,

Thank you for your interest in contributing to MetaMask. This issue covers a lot of work and should be broken down into smaller PRs. Therefore, we won't be assigning this issue to anyone in particular.

Please make sure to carefully review the acceptance criteria to ensure that your PR meets all the requirements. This will help prevent your PR from being closed. A good starting point is to read the Getting Started and Contributor Docs. These resources will guide you on how to get started and what to keep in mind while contributing.

Thanks again, and I look forward to your contributions!

MridulY commented 4 months ago

@georgewrmarshall Thanks for the reply I know this issue should be break down in smaller PR because of the components and I’ll do the same

MetaMask / metamask-mobile