search

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.15k stars 1.11k forks source link

[Sentry] Error while checking incoming transactions TypeError: Cannot read property 'toLowerCase of undefined #7080

Closed olenapankina closed 9 months ago

olenapankina commented 1 year ago

Tested on Samsung Galaxy M21 Android 12, One UI Core version 4.1 Pixel 4a API 31

commit c785d3d786963ab1f1d413541f63b21903885c73

Console error occurs after changing the password to the one with lowercase symbols only "12345678a". Selected auth method - password The error occurs regardless of whether the Transaction tab was opened. image image image

olenapankina commented 1 year ago

Might be related/fixed by https://github.com/MetaMask/metamask-mobile/pull/7056 cc @jpcloureiro

jpcloureiro commented 1 year ago

Hi Olena.

The error appears to come from the TransactionController, more specifically from IncomingTransactionHelper

Unfortunately, it won't be fixed by #7056

It might be worth checking the @metamask/transaction-controller patch where toLowerCase function is called.

seaona commented 12 months ago

Encountered the same issue, logging out and logging in again to the Wallet in QA build. In my case, my password didn't have a lower case.

Screenshot from 2023-10-20 10-35-00

I think this could be classified as sev2? The wallet seems to continue to work normally after the error.

cc @bschorchit @cryptotavares maybe this should be assigned to Confirmations?

hesterbruikman commented 9 months ago

Closing in favor of #8201 as it includes Sentry logs and an approach to resolve. #8201 is assigned to and investigated by team-confirmations-system

cc @gauthierpetetin

sentry-io[bot] commented 5 months ago

Sentry Issue: METAMASK-MOBILE-2B61

sentry-io[bot] commented 5 months ago

Sentry Issue: METAMASK-MOBILE-2B4A