Clean up redux-persist's transform functions - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.13k stars 1.1k forks source link

Clean up redux-persist's transform functions #7204

Open Cal-L opened 1 year ago

Cal-L commented 1 year ago

Description

This ticket aims to clean up the transform functions that are being used by redux-persist. The tasks include removing old fields and fixing typos. Here are two areas to address so far: https://github.com/MetaMask/metamask-mobile/blob/main/app/store/index.ts#L78 https://github.com/MetaMask/metamask-mobile/blob/df4b055e91807d8081d6884b8d9c585bccbd3f2e/app/store/index.ts#L92

Technical Details

Address typo comment - https://github.com/MetaMask/metamask-mobile/blob/main/app/store/index.ts#L78
Remove old field - https://github.com/MetaMask/metamask-mobile/blob/df4b055e91807d8081d6884b8d9c585bccbd3f2e/app/store/index.ts#L92

Acceptance Criteria

tokensChainsCache should be omitted from persisted data
We are no longer attempting to deconstruct undefined fields in the transform functions

kshavp commented 1 year ago

@Cal-L I have submitted a PR regarding this issue.