MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.13k stars 1.1k forks source link

Update preferences controller to v4.4.2 #7488

Closed tommasini closed 10 months ago

tommasini commented 11 months ago

What is this about?

The preferences controller can be updated to v4.4.2 independently since we already are on node 16. We will need to check the preferences-controller patch and re-do the patch, accordingly with the changes that doesn't need to be patched anymore like:

Scenario

Test the scenarios mentioned in these tickets: https://github.com/MetaMask/mobile-planning/issues/1166 https://github.com/MetaMask/mobile-planning/issues/1216 https://github.com/MetaMask/mobile-planning/issues/822


Scenario: Importing wallet with multiple accounts and switch between accounts on different networks
 Given I import a wallet with 5 accounts
 When I am mainnet 
 And I switch from Account A to B
 Then my account B balance should appear correctly
 When I switch networks
 And I switch from account B to account C 
 Then my balance should update correctly. 

Scenario: Importing account with a token balance and then removing it from your wallet
 Given I import a wallet
 And I am on the wallet view
 When I import an account
 Then my account balance appeared correctly
 When I remove that imported account
 Then the removed account wallet balance does not transfer to my other wallet accounts

Scenario: Importing wallet with multiple accounts and switch between accounts on different networks
 Given I import a wallet with a balance
 And I update my currency from Native to Fiat
 When I submit a transaction
 Then the transaction should be submitted correctly.
 And my account balance should update correctly.

Design

No response

Technical Details

Threat Modeling Framework

No response

Acceptance Criteria

References

tommasini commented 11 months ago

Hey team! Please add your planning poker estimate with Zenhub @Andepande @Cal-L @chrisleewilcox @cortisiko @frankvonhoven @jpcloureiro @MarioAslau @NicolasMassart @SamuelSalas