MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.15k stars 1.11k forks source link

[BUG] Fix the TokenRateController API #7903

Closed sethkfman closed 9 months ago

sethkfman commented 11 months ago

What is this about?

This issue is to replace the CoinGecko API on the TokenRates controller. The API should be replaced with the public PriceAPI written by the codefi team which is documented here.

Scenario

Design

No response

Technical Details



- Create a core PR that applies these changes to the TokenRatesController
- Test the API calls and confirm data objects have the same format as what CoinGecko returns

### Data flow
![image](https://github.com/MetaMask/metamask-mobile/assets/46944231/c3f5fd73-4e99-4588-bb1d-d944d8796a47)

### Threat Modeling Framework

This is a public API and does not require an API token.

### Acceptance Criteria

Token rates are displaying with the new API integration when there is a network connection.

### References

Slack - https://consensys.slack.com/archives/C065W3877E3/p1700574338429709
sethkfman commented 11 months ago

Related to issue #7887

tommasini commented 9 months ago

Moving this to done since it was done on this https://github.com/MetaMask/metamask-mobile/pull/8143