feat: Move metrics anonymous id to a nil UUID 00000000-0000-0000-0000-000000000000

NicolasMassart commented 9 months ago

What is this about?

Move anonymous id from 0x0000000000000000 to to a nil 00000000-0000-0000-0000-000000000000 UUID format. This will allow consistency in ids.

[!IMPORTANT] verify impact on the server side of metrics system

Scenario

No response

Design

No response

Technical Details

replace /app/core/Analytics/MetaMetrics.constants.ts id value by 00000000-0000-0000-0000-000000000000
update app/core/Analytics/MetaMetrics.test.ts as this nil value was used as test value for regular ids. Use for instance 74686973-2069-7320-7465-737420696421 (means "this is test id!" in ascii hex code)

Threat Modeling Framework

No response

Acceptance Criteria

METAMETRICS_ANONYMOUS_ID updated to nil UUID
no conflict or feature broken on server side
changes made on server side by data team if needed

Stakeholder review needed before the work gets merged

[X] Engineering (needed in most cases)
[ ] Design
[ ] Product
[ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
[ ] Security
[ ] Legal
[ ] Marketing
[ ] Management (please specify)
[X] Other (please specify) : Data team

References

No response

gauthierpetetin commented 9 months ago

We'll keep this issue aside for now and come back to it once we have the feature that allows to merge two users in MixPanel + BigQuery, probably by end of Q1 2024.

NicolasMassart commented 8 months ago

To be done after migration to segment v2 on server side

NicolasMassart commented 2 months ago

Check https://github.com/MetaMask/metamask-extension/pull/13237 and https://docs.mixpanel.com/docs/tracking-methods/id-management/identifying-users-simplified because maybe there's something preventing the use of UUIDs on our Mixpanel configuration

MetaMask / metamask-mobile