Adapt to EIP-1193 provider changes - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.04k stars 1.06k forks source link

Adapt to EIP-1193 provider changes #9037

Open mcmire opened 3 months ago

mcmire commented 3 months ago

What is this about?

After SafeEventEmitterProvider is updated to support EIP-1193 and a new version of @metamask/eth-json-rpc-provider is released, we should adapt to the changes:

We should upgrade @metamask/network-controller, as that will incorporate the changes to @metamask/eth-json-rpc-provider.
At this point, calling sendAsync will be deprecated; we should use request instead.
- We re-bind sendAsync in Engine.ts.
- We also assume that the provider has a sendAsync method in AddressElement.test.tsx.

Scenario

(N/A)

Design

(N/A)

Technical Details

(Given above)

Threat Modeling Framework

(N/A)

Acceptance Criteria

(Given above)

Stakeholder review needed before the work gets merged

[ ] Engineering (needed in most cases)
[ ] Design
[ ] Product
[ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
[ ] Security
[ ] Legal
[ ] Marketing
[ ] Management (please specify)
[ ] Other (please specify)

References

No response

desi commented 1 month ago

Maybe blocked controller upgrades at the moment.