[Bug]: Passing extra hex data in a tx is not correctly handled - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.12k stars 1.1k forks source link

[Bug]: Passing extra hex data in a tx is not correctly handled #9044

Open seaona opened 5 months ago

seaona commented 5 months ago

Describe the bug

If I pass the value ffffffffffffffff I see the correct approve amount (which is 18.446744073709551615)
If I pass the value with extra data appended ffffffffffffffff360c6ebe I see that the approve amount is now the one corresponding to the complete hex value (which is 79228162514.264337590155767486)

Context: there is also an issue with extra calldata in extension https://github.com/MetaMask/metamask-extension/pull/23527 Thread: https://consensys.slack.com/archives/C02GENU377A/p1710539055935619

Expected behavior

Display the correct amount in approve tx
Highlight the extra hex data somehow -- design needed @bschorchit @SayaGT

Screenshots/Recordings

Without extra hex data

With extra hex data

Steps to reproduce

Go to the test dapp locally
Add extra hex data in the approve tx by appending 360c6ebe in the data field ......ffffffffffffffff360c6ebe

Error messages or log output

No response

Version

7.17.0 but it's an old issue - we never handled that

Build type

None

Device

Pixel 6

Operating system

Android

Additional context

No response

Severity

No response

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.