MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.16k stars 1.11k forks source link

[Bug]: Transactions - Speeding up a Legacy transaction displays EIP1559 gas modal #9621

Closed seaona closed 2 months ago

seaona commented 5 months ago

Describe the bug

Whenever I want to speed up a Legacy transaction I see how the gas modal displays the EIP1559 gas values, instead of the legacy ones (Gas Price & Gas Limit)

Expected behavior

Display the Legacy Gas params

Screenshots/Recordings

https://github.com/MetaMask/metamask-mobile/assets/54408225/7444222e-e377-49ec-a666-7c7c4f9f9f4b

Legacy gas values

screencap-2024-05-14T125911 675Z

Speed up gas values for legacy (incorrect ones)

screencap-2024-05-14T125744 252Z

Steps to reproduce

  1. Go to the test dapp
  2. Trigger a Send Legacy tx
  3. Check gas values are correct (Gas limit and Gas Price)
  4. Accept the tx
  5. Now try to Speed it up
  6. Check gas values -- we are displaying EIP1559 gas value params

Error messages or log output

No response

Version

main branch (but seems an old issue also affecting prod)

Build type

None

Device

Pixel 6

Operating system

iOS, Android

Additional context

No response

Severity

No response

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] commented 2 months ago

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.