MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

Lock icon missing on tap and hold to reveal for secrets #9909

Open plasmacorral opened 1 month ago

plasmacorral commented 1 month ago

What is this about?

Observed this while testing a QA build of PR 9070, and confirmed this is also observed on a QA build of release v7.23.0.

Expected: When a user is trying to reveal a secret, the CTA should include a lock icon.

Current: Lock icon is missing across Android and iOS as well as light and dark modes. User currently sees a black circle.

Scenario

Reproduction:

SRP

  1. Import SRP and setup wallet
  2. Access Settings> Security & Privacy
  3. tap reveal SRP
  4. complete the quiz
  5. authenticate with password
  6. Observe black circle in Hold to reveal CTA

Private key

  1. Import SRP and setup wallet
  2. Access Settings> Security & Privacy
  3. tap reveal private key
  4. authenticate with password
  5. Observe black circle in Hold to reveal CTA

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

References

Expectation from some design files

As observed on SRP reveal in Android 12 with qa build of v7.23.0:

plasmacorral commented 1 month ago

Confirmed in slack this is not a DS icon.