search

MetaMask / metamask-module-template

A simple template repository for starting new modules in the latest MetaMask fashion.
27 stars 23 forks source link

Reorganize GitHub Action workflows #149

Closed Gudahtt closed 1 year ago

Gudahtt commented 1 year ago

The workflows have been reorganized to use one "main" workflow for any push to the main branch, with additional jobs being triggered from there using workflow_call. This mirrors the change made recently in the controllers repository as part of the monorepo branch.

This makes more sense semantically every since we moved the publish step to be triggered by a push to main. Since then, it seend wrong to call that workflow "build-test" because it also did publishing. Now the "build-test" workflow is distinct, and it's the "main" workflow that triggers publishing.

Gudahtt commented 1 year ago

Oh right. We're using pull_request here, not pull_request_target, so this might not be triggering CI properly.

mcmire commented 1 year ago

Should this be pull_request_target? It seems like there is no real difference compared with pull_request based on what we want to do here. Although you're right, CI isn't being run here for some reason, which is strange as it seemed to work fine for controllers.

Gudahtt commented 1 year ago

Ah, I see why it wasn't running. There was a mistake in main.yml.

I was getting mixed up, it's pull_request_target that doesn't run on PRs. pull_request should work.