search

MetaMask / metamask-module-template

A simple template repository for starting new modules in the latest MetaMask fashion.
27 stars 23 forks source link

Ensure required status check always runs #151

Closed Gudahtt closed 1 year ago

Gudahtt commented 1 year ago

Apparently GitHub allows merging PRs with required status checks that have been skipped. This makes our CI checks ineffective since we've split them into separate jobs, because one job failing results in subsequent jobs being skipped (including "All jobs passed")

This has been corrected by ensuring the "All jobs passed" job always runs. This job now checks to see whether the "All jobs completed" job ran, which indicates whether anything has failed.

This was based upon the solution described in this blog post: https://brunoscheufler.com/blog/2022-04-09-the-required-github-status-check-that-wasnt

Gudahtt commented 1 year ago

This PR demonstrates that this works: https://github.com/MetaMask/metamask-module-template/pull/150

mcmire commented 8 months ago

For posterity, the URL above seems to time out now, but is archived here: https://web.archive.org/web/20230402203815/https://brunoscheufler.com/blog/2022-04-09-the-required-github-status-check-that-wasnt