Remove the `-x` flag from Bash scripts

MetaMask / metamask-module-template

A simple template repository for starting new modules in the latest MetaMask fashion.

26 stars 23 forks source link

Remove the `-x` flag from Bash scripts #201

Closed Gudahtt closed 1 year ago

Gudahtt commented 1 year ago

The -x flag is typically used for debugging. When used in production, it can clutter the console output and make it difficult to tell what's happening.

The flag has been removed from the two small Bash scripts in this template.

Examples

This was done recently in this PR: https://github.com/MetaMask/eth-trezor-keyring/pull/182

Gudahtt commented 1 year ago

Sure, that might make sense for get.sh at least. prepack.sh is local-only, so it would always be unset there.

Gudahtt commented 1 year ago

I have updated the script to set -x if RUNNER_DEBUG is set (see https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables)