MetaMask / metamask-module-template

A simple template repository for starting new modules in the latest MetaMask fashion.
26 stars 23 forks source link

ci: Run compatibility test ignoring lockfile #215

Closed legobeat closed 1 year ago

legobeat commented 1 year ago

This adds an additional run of tests against a state where yarn.lock is removed prior to the installation. This is intended to catch e.g. regressions and mislabeled breakage in updated transitive dependencies.

This will map more closely to what users get when installing the released package from registry.

Left out the intermediate versions of node as an optimization. The normal cache is still used since significant overlap is expected.

Potential future improvements

legobeat commented 1 year ago
  ➤ YN0013: │ 10 packages were already cached, 743 had to be fetched
  ➤ YN0019: │ 199 packages appeared to be unused and were removed

:dancers:

In case the overhead in the extra loading of packages is not palatable, I think most situations would be covered by dropping tested versions to only the lowest 16.

legobeat commented 1 year ago

@Mrtenz

One example scenario:

This breakage would not get caught in CI tests nor developer environments before this change until someone explicitly causes a lockfile bump, but could trigger breakage for users and dependents on alpha from the release of ceta.