MetaMask / metamask-module-template

A simple template repository for starting new modules in the latest MetaMask fashion.
26 stars 23 forks source link

Enable Prettier for changelog validation #219

Closed Mrtenz closed 9 months ago

Mrtenz commented 11 months ago

This enables Prettier for changelog validation.

mcmire commented 9 months ago

This should be unblocked now.

mcmire commented 9 months ago

Hmm. It doesn't look like the CHANGELOG needs that extra line for some reason.

Inikowu commented 9 months ago

Inikowu-Isaac.zip package.json

mcmire commented 9 months ago

It looks like when we validate the changelogs in CI, we manually run yarn auto-changelog. Perhaps we should not do this anymore? I see that we are doing this because we may need to pass --rc depending on whether the current branch is a release branch or not, but we could extract the existing lint:changelog package script to a shell script and then add the same if statement that exists in the CI config. That way it gets run consistently locally and in CI.

Mrtenz commented 9 months ago

It looks like when we validate the changelogs in CI, we manually run yarn auto-changelog. Perhaps we should not do this anymore? I see that we are doing this because we may need to pass --rc depending on whether the current branch is a release branch or not, but we could extract the existing lint:changelog package script to a shell script and then add the same if statement that exists in the CI config. That way it gets run consistently locally and in CI.

I just swapped it out for yarn lint:changelog, which seems to work fine, and seems easier than adding a script.

mcmire commented 9 months ago

Ah I think the PR I merged might have created merge conflicts, sorry.