search

MetaMask / metamask-module-template

A simple template repository for starting new modules in the latest MetaMask fashion.
26 stars 23 forks source link

Drop support for Node.js 16 #221

Closed Mrtenz closed 9 months ago

Mrtenz commented 11 months ago

Node.js 16 is EOL, so we can drop support for it.

Blocking

Blocked by

MajorLift commented 11 months ago

We might want to update the engines.node field in package.json to >=18.0.0 as well.

MajorLift commented 11 months ago

Line 93-94 of constraints.pro also needs to be updated:

% The package must specify a minimum Node version of 18.
gen_enforced_field(WorkspaceCwd, 'engines.node', '>=18.0.0').
mcmire commented 10 months ago

On a surface level now that mobile is on Node 18 I agree with this. I guess this assumes that we want to go with #216, however? It seemed that the conversation about node.engines wasn't quite resolved (I know Mark raised one about that vs. .nvmrc in Slack a while back).

mcmire commented 9 months ago

I've fixed the merge conflicts on this PR. I also took the liberty to update to 18.18 (the current minor version as of this writing).