search

MetaMask / metamask-module-template

A simple template repository for starting new modules in the latest MetaMask fashion.
26 stars 23 forks source link

Unvendor Yarn; favor Corepack for installation #243

Closed mcmire closed 3 months ago

mcmire commented 4 months ago

According to the Yarn documentation, Yarn no longer needs to be bundled with a project, but rather, installing Yarn ought to be done using Corepack, which is shipped in modern Node versions. This commit removes the Yarn binary from the repo and updates the installation instructions in the README to match.

Examples

(None)

legobeat commented 4 months ago

Looks like corepack support is still pending in @actions/setup-node: https://github.com/actions/setup-node/pull/901

legobeat commented 4 months ago

Devs will still need to run corepack enable locally but other than that it seems like we can hack around it like #244 .

legobeat commented 4 months ago

I kind of dislike the hacks we have to do here. It makes the GitHub workflow files longer and more complicated than they need to be.

Agreed. I still find it less ugly and less objectively bad than redundantly checking in the entire minified yarn cjs file without additional integrity-checking in every repo...

mcmire commented 4 months ago

Yeah, that's true. Okay, I'm convinced. ✅

legobeat commented 3 months ago

@mcmire ping