MetaMask / metamask-sdk

The simplest yet most secure way to connect your blockchain-based applications to millions of MetaMask Wallet users.
https://metamask.io/sdk/
Other
188 stars 115 forks source link

chore: improve the deeplink handling for MetaMask SDK on iOS #1002

Closed omridan159 closed 2 months ago

omridan159 commented 2 months ago

Explanation

This PR refines the existing setupDeeplinkHandling function to enhance the handling of deep links for the MetaMask SDK on iOS. The updated logic ensures that only valid URLs with the expected host (mmsdk) are processed, while malformed or unexpected URLs are ignored with appropriate warnings. The changes improve the robustness and reliability of deep link handling, making it more resilient to potential errors. This refactor does not introduce new functionality but optimizes the current implementation for better performance and error handling.

References

Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.57%. Comparing base (5af7cbf) to head (22f5cf0). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1002 +/- ## ======================================= Coverage 80.57% 80.57% ======================================= Files 177 177 Lines 3990 3990 Branches 990 990 ======================================= Hits 3215 3215 Misses 775 775 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud