Closed abretonc7s closed 1 month ago
Attention: Patch coverage is 67.25664%
with 37 lines
in your changes missing coverage. Please review.
Project coverage is 78.81%. Comparing base (
1e41819
) to head (9a56aaf
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Explanation
A potential issue was discovered if a user terminates their connection without an internet connection.
The behavior to disconnect is to send a terminate message to the server, which will relay it to the dApp to inform that the connection has been destroyed.
However, if the wallet doesn't have an active internet connection, it would delete the connection without sending the event, potentially leaving the dApp uninformed that the connection was destroyed.
In this case, the dApp would need to provide a mechanism to disconnect and create a new connection.
To fix the issue, we have two approaches:
Only remove the connection after the terminate message has been acknowledged by the server. Remove the connection from the UI directly (set the state to removed) and wait for acknowledgment from the server before fully removing it from storage.
References
Checklist