MetaMask / metamask-sdk

The simplest yet most secure way to connect your blockchain-based applications to millions of MetaMask Wallet users.
https://metamask.io/sdk/
Other
188 stars 115 forks source link

chore: update connect method to return accounts array #1023

Closed elefantel closed 2 months ago

elefantel commented 2 months ago

Explanation

This PR updates the connect method to return an array of accounts instead of the selected account to match it with other sdks. The PR also updates dapp demo to likewise

References

Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.00%. Comparing base (cb7c7d9) to head (4230e4b). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1023 +/- ## ======================================= Coverage 80.00% 80.00% ======================================= Files 177 177 Lines 4025 4025 Branches 997 997 ======================================= Hits 3220 3220 Misses 805 805 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud